Remove need for separate .rubocop_cask.yml.

This commit is contained in:
Markus Reiter 2020-08-31 00:13:15 +02:00
parent fecc701ac0
commit 2b029b2744
3 changed files with 30 additions and 37 deletions

View File

@ -8,6 +8,30 @@ AllCops:
# enable all pending rubocops # enable all pending rubocops
NewCops: enable NewCops: enable
Cask/Desc:
Description: 'Ensure that the desc stanza conforms to various content and style checks.'
Enabled: true
Cask/HomepageMatchesUrl:
Description: 'Ensure that the homepage and url match, otherwise add a comment. More info at https://github.com/Homebrew/homebrew-cask/blob/HEAD/doc/cask_language_reference/stanzas/url.md#when-url-and-homepage-hostnames-differ-add-a-comment'
Enabled: true
Cask/HomepageUrlTrailingSlash:
Description: 'Ensure that the homepage url has a slash after the domain name.'
Enabled: true
Cask/NoDslVersion:
Description: 'Do not use the deprecated DSL version syntax in your cask header.'
Enabled: true
Cask/StanzaGrouping:
Description: 'Ensure that cask stanzas are grouped correctly. More info at https://github.com/Homebrew/homebrew-cask/blob/HEAD/doc/cask_language_reference/readme.md#stanza-order'
Enabled: true
Cask/StanzaOrder:
Description: 'Ensure that cask stanzas are sorted correctly. More info at https://github.com/Homebrew/homebrew-cask/blob/HEAD/doc/cask_language_reference/readme.md#stanza-order'
Enabled: true
# enable all formulae audits # enable all formulae audits
FormulaAudit: FormulaAudit:
Enabled: true Enabled: true
@ -195,11 +219,11 @@ Style/ClassVars:
Exclude: Exclude:
- '**/developer/bin/*' - '**/developer/bin/*'
# most of our APIs are internal so don't require docs # Don't enforce documentation in casks or formulae.
Style/Documentation: Style/Documentation:
Enabled: false Enabled: false
# don't want this for formulae but re-enabled for Library/Homebrew # Not used for casks and formulae.
Style/FrozenStringLiteralComment: Style/FrozenStringLiteralComment:
Enabled: false Enabled: false

View File

@ -1,35 +1,4 @@
# TODO: This file can be deleted once https://github.com/Homebrew/brew/pull/8542
# is in a stable release and `rubocop.yml` has been removed from all cask taps.
inherit_from: ./Homebrew/.rubocop.yml inherit_from: ./Homebrew/.rubocop.yml
Cask/Desc:
Description: 'Ensure that the desc stanza conforms to various content and style checks.'
Enabled: true
Cask/HomepageMatchesUrl:
Description: 'Ensure that the homepage and url match, otherwise add a comment. More info at https://github.com/Homebrew/homebrew-cask/blob/HEAD/doc/cask_language_reference/stanzas/url.md#when-url-and-homepage-hostnames-differ-add-a-comment'
Enabled: true
Cask/HomepageUrlTrailingSlash:
Description: 'Ensure that the homepage url has a slash after the domain name.'
Enabled: true
Cask/NoDslVersion:
Description: 'Do not use the deprecated DSL version syntax in your cask header.'
Enabled: true
Cask/StanzaGrouping:
Description: 'Ensure that cask stanzas are grouped correctly. More info at https://github.com/Homebrew/homebrew-cask/blob/HEAD/doc/cask_language_reference/readme.md#stanza-order'
Enabled: true
Cask/StanzaOrder:
Description: 'Ensure that cask stanzas are sorted correctly. More info at https://github.com/Homebrew/homebrew-cask/blob/HEAD/doc/cask_language_reference/readme.md#stanza-order'
Enabled: true
# don't want these for casks but re-enabled for Library/Homebrew
Style/FrozenStringLiteralComment:
Enabled: false
Style/Documentation:
Enabled: false
Metrics/BlockLength:
Enabled: false

View File

@ -27,7 +27,7 @@ module Cask
args = [ args = [
"--force-exclusion", "--force-exclusion",
"--config", "#{HOMEBREW_LIBRARY}/.rubocop_cask.yml" "--config", HOMEBREW_LIBRARY/".rubocop.yml"
] ]
if json if json