diff --git a/Library/Homebrew/cmd/postinstall.rb b/Library/Homebrew/cmd/postinstall.rb index 95bd3f8ef0..798907339c 100644 --- a/Library/Homebrew/cmd/postinstall.rb +++ b/Library/Homebrew/cmd/postinstall.rb @@ -21,12 +21,10 @@ module Homebrew args << "--devel" end - if Sandbox.available? && ARGV.sandbox? - Sandbox.print_sandbox_message - end + Sandbox.print_sandbox_message if Sandbox.formula?(formula) Utils.safe_fork do - if Sandbox.available? && ARGV.sandbox? + if Sandbox.formula?(formula) sandbox = Sandbox.new formula.logs.mkpath sandbox.record_log(formula.logs/"sandbox.postinstall.log") diff --git a/Library/Homebrew/cmd/test.rb b/Library/Homebrew/cmd/test.rb index 0218e1c80d..495ea8ec8a 100644 --- a/Library/Homebrew/cmd/test.rb +++ b/Library/Homebrew/cmd/test.rb @@ -57,12 +57,10 @@ module Homebrew args << "--devel" end - if Sandbox.available? && !ARGV.no_sandbox? - Sandbox.print_sandbox_message - end + Sandbox.print_sandbox_message if Sandbox.test? Utils.safe_fork do - if Sandbox.available? && !ARGV.no_sandbox? + if Sandbox.test? sandbox = Sandbox.new f.logs.mkpath sandbox.record_log(f.logs/"sandbox.test.log") diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb index 54581b2329..03c9f83145 100644 --- a/Library/Homebrew/formula_installer.rb +++ b/Library/Homebrew/formula_installer.rb @@ -588,15 +588,13 @@ class FormulaInstaller #{formula.path} ].concat(build_argv) - if Sandbox.available? && ARGV.sandbox? - Sandbox.print_sandbox_message - end + Sandbox.print_sandbox_message if Sandbox.formula?(formula) Utils.safe_fork do # Invalidate the current sudo timestamp in case a build script calls sudo system "/usr/bin/sudo", "-k" - if Sandbox.available? && ARGV.sandbox? + if Sandbox.formula?(formula) sandbox = Sandbox.new formula.logs.mkpath sandbox.record_log(formula.logs/"sandbox.build.log") diff --git a/Library/Homebrew/sandbox.rb b/Library/Homebrew/sandbox.rb index 4823baf7f8..133bdb83c4 100644 --- a/Library/Homebrew/sandbox.rb +++ b/Library/Homebrew/sandbox.rb @@ -3,11 +3,24 @@ require "tempfile" class Sandbox SANDBOX_EXEC = "/usr/bin/sandbox-exec".freeze + SANDBOXED_TAPS = [ + "homebrew/core", + ].freeze def self.available? OS.mac? && File.executable?(SANDBOX_EXEC) end + def self.formula?(formula) + return false unless available? + ARGV.sandbox? || SANDBOXED_TAPS.include?(formula.tap.to_s) + end + + def self.test? + return false unless available? + !ARGV.no_sandbox? + end + def self.print_sandbox_message unless @printed_sandbox_message ohai "Using the sandbox" diff --git a/Library/Homebrew/test/test_sandbox.rb b/Library/Homebrew/test/test_sandbox.rb index dc907d428d..cb33c3ffa4 100644 --- a/Library/Homebrew/test/test_sandbox.rb +++ b/Library/Homebrew/test/test_sandbox.rb @@ -13,6 +13,28 @@ class SandboxTest < Homebrew::TestCase @dir.rmtree end + def test_formula? + f = formula { url "foo-1.0" } + f2 = formula { url "bar-1.0" } + f2.stubs(:tap).returns(Tap.fetch("test/tap")) + + ARGV.stubs(:sandbox?).returns true + assert Sandbox.formula?(f), + "Formulae should be sandboxed if --sandbox was passed." + + ARGV.stubs(:sandbox?).returns false + assert Sandbox.formula?(f), + "Formulae should be sandboxed if in a sandboxed tap." + refute Sandbox.formula?(f2), + "Formulae should not be sandboxed if not in a sandboxed tap." + end + + def test_test? + ARGV.stubs(:no_sandbox?).returns false + assert Sandbox.test?, + "Tests should be sandboxed unless --no-sandbox was passed." + end + def test_allow_write @sandbox.allow_write @file @sandbox.exec "touch", @file