admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

formula_auditor: check for aliases only core formulae

Browse Source
This commit is contained in:
Alexander Bayandin 2020-12-24 13:59:59 +00:00
parent 1e68ce5a3f
commit 2aaa83d398
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Library/Homebrew/formula_auditor.rb
View File

@ -235,11 +235,6 @@ module Homebrew
problem "Dependency '#{dep.name}' was renamed; use new name '#{dep_f.name}'." problem "Dependency '#{dep.name}' was renamed; use new name '#{dep_f.name}'."
end end
if self.class.aliases.include?(dep.name) && dep_f.core_formula?
problem "Dependency '#{dep.name}' from homebrew/core is an alias; " \
"use the canonical name '#{dep.to_formula.full_name}'."
end
if @core_tap && if @core_tap &&
@new_formula && @new_formula &&
dep_f.keg_only? && dep_f.keg_only? &&
@ -272,6 +267,10 @@ module Homebrew
next unless @core_tap next unless @core_tap
if self.class.aliases.include?(dep.name)
problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'."
end
if dep.tags.include?(:recommended) || dep.tags.include?(:optional) if dep.tags.include?(:recommended) || dep.tags.include?(:optional)
problem "Formulae in homebrew/core should not have optional or recommended dependencies" problem "Formulae in homebrew/core should not have optional or recommended dependencies"
end end