admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #1424 from MikeMcQuaid/audit-more-test-system

Browse Source 
audit: check more unscoped test calls.
This commit is contained in:
Mike McQuaid 2016-11-02 21:50:54 -04:00 committed by GitHub
commit 2a865f085e
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Library/Homebrew/dev-cmd/audit.rb
View File

@ -740,8 +740,10 @@ class FormulaAuditor
bin_names += dir.children.map(&:basename).map(&:to_s) bin_names += dir.children.map(&:basename).map(&:to_s)
end end
bin_names.each do |name| bin_names.each do |name|
if text =~ /test do.*system\s+['"]#{name}/m ["system", "shell_output", "pipe_output"].each do |cmd|
problem %(fully scope test system calls e.g. system "\#{bin}/#{name}") if text =~ /(def test|test do).*#{cmd}[\(\s]+['"]#{name}[\s'"]/m
problem %(fully scope test #{cmd} calls e.g. #{cmd} "\#{bin}/#{name}")
end
end end
end end