Make sure uninstall is called before artifacts are removed.

2017-02-16 17:10:40 +01:00 · 2017-02-16 17:10:40 +01:00 · 2a21991b1f
commit 2a21991b1f
parent 5a2a063802
1 changed files with 6 additions and 0 deletions
--- a/Library/Homebrew/cask/lib/hbc/installer.rb
+++ b/Library/Homebrew/cask/lib/hbc/installer.rb
@ -318,7 +318,13 @@ module Hbc
    def uninstall_artifacts
      odebug "Un-installing artifacts"
      artifacts = Artifact.for_cask(@cask, command: @command, force: force)
+
+      # Make sure the `uninstall` stanza is run first, as it
+      # may depend on other artifacts still being installed.
+      artifacts = artifacts.sort_by { |a| a.is_a?(Artifact::Uninstall) ? -1 : 1 }
+
      odebug "#{artifacts.length} artifact/s defined", artifacts
+
      artifacts.each do |artifact|
        next unless artifact.respond_to?(:uninstall_phase)
        odebug "Un-installing artifact of class #{artifact.class}"