From a998c364f4394b30ca45f7e100c51652d26389d6 Mon Sep 17 00:00:00 2001 From: Kid <44045911+kidonng@users.noreply.github.com> Date: Mon, 14 Jun 2021 23:19:21 +0800 Subject: [PATCH 1/2] Reduce potential modifications to frozen string --- Library/Homebrew/requirement.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/requirement.rb b/Library/Homebrew/requirement.rb index 33e97cf28f..ce4db612a1 100644 --- a/Library/Homebrew/requirement.rb +++ b/Library/Homebrew/requirement.rb @@ -142,8 +142,8 @@ class Requirement def infer_name klass = self.class.name || self.class.to_s - klass.sub!(/(Dependency|Requirement)$/, "") - klass.sub!(/^(\w+::)*/, "") + klass = klass.sub(/(Dependency|Requirement)$/, "") + klass = klass.sub(/^(\w+::)*/, "") return klass.downcase if klass.present? return @cask if @cask.present? From 8b28731d33f75effb95cf50887f0c207d80bb6e7 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Tue, 15 Jun 2021 12:52:39 +0100 Subject: [PATCH 2/2] requirement: tweak syntax. --- Library/Homebrew/requirement.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/requirement.rb b/Library/Homebrew/requirement.rb index ce4db612a1..a7718345db 100644 --- a/Library/Homebrew/requirement.rb +++ b/Library/Homebrew/requirement.rb @@ -143,7 +143,7 @@ class Requirement def infer_name klass = self.class.name || self.class.to_s klass = klass.sub(/(Dependency|Requirement)$/, "") - klass = klass.sub(/^(\w+::)*/, "") + .sub(/^(\w+::)*/, "") return klass.downcase if klass.present? return @cask if @cask.present?