Merge pull request #12563 from samford/livecheck/avoid-duplicate-urls

Livecheck: Avoid duplicate URLs

Library/Homebrew/livecheck/livecheck.rb

@@ -484,7 +484,7 @@ module Homebrew
         T.absurd(formula_or_cask)
       end
 
-      urls.compact
+      urls.compact.uniq
     end
 
     # Preprocesses and returns the URL used by livecheck.
@@ -609,24 +609,16 @@ module Homebrew
         end
       end
 
+      checked_urls = []
       # rubocop:disable Metrics/BlockLength
       urls.each_with_index do |original_url, i|
-        if debug
-          puts
-          if livecheck_url.is_a?(Symbol)
-            # This assumes the URL symbol will fit within the available space
-            puts "URL (#{livecheck_url}):".ljust(18, " ") + original_url
-          else
-            puts "URL:              #{original_url}"
-          end
-        end
-
         # Only preprocess the URL when it's appropriate
         url = if STRATEGY_SYMBOLS_TO_SKIP_PREPROCESS_URL.include?(livecheck_strategy)
           original_url
         else
           preprocess_url(original_url)
         end
+        next if checked_urls.include?(url)
 
         strategies = Strategy.from_url(
           url,
@@ -639,6 +631,13 @@ module Homebrew
         strategy_name = livecheck_strategy_names[strategy]
 
         if debug
+          puts
+          if livecheck_url.is_a?(Symbol)
+            # This assumes the URL symbol will fit within the available space
+            puts "URL (#{livecheck_url}):".ljust(18, " ") + original_url
+          else
+            puts "URL:              #{original_url}"
+          end
           puts "URL (processed):  #{url}" if url != original_url
           if strategies.present? && verbose
             puts "Strategies:       #{strategies.map { |s| livecheck_strategy_names[s] }.join(", ")}"
@@ -674,6 +673,7 @@ module Homebrew
         match_version_map = strategy_data[:matches]
         regex = strategy_data[:regex]
         messages = strategy_data[:messages]
+        checked_urls << url
 
         if messages.is_a?(Array) && match_version_map.blank?
           puts messages unless json

Library/Homebrew/test/livecheck/livecheck_spec.rb

@@ -44,6 +44,15 @@ describe Homebrew::Livecheck do
     RUBY
   end
 
+  let(:f_duplicate_urls) do
+    formula("test_duplicate_urls") do
+      desc "Test formula with a duplicate URL"
+      homepage "https://github.com/Homebrew/brew.git"
+      url "https://brew.sh/test-0.0.1.tgz"
+      head "https://github.com/Homebrew/brew.git"
+    end
+  end
+
   describe "::resolve_livecheck_reference" do
     context "when a formula/cask has a livecheck block without formula/cask methods" do
       it "returns [nil, []]" do
@@ -144,6 +153,7 @@ describe Homebrew::Livecheck do
     it "returns the list of URLs to check" do
       expect(livecheck.checkable_urls(f)).to eq([stable_url, head_url, homepage_url])
       expect(livecheck.checkable_urls(c)).to eq([cask_url, homepage_url])
+      expect(livecheck.checkable_urls(f_duplicate_urls)).to eq([stable_url, head_url])
     end
   end