admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Pass args in style instead of using global args.

Browse Source
This commit is contained in:
Markus Reiter 2020-07-26 09:44:46 +02:00
parent bd0346e083
commit 291eee74c4
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/dev-cmd/style.rb
View File

@ -51,7 +51,7 @@ module Homebrew
only_cops = args.only_cops only_cops = args.only_cops
except_cops = args.except_cops except_cops = args.except_cops
options = { fix: args.fix? } options = { fix: args.fix?, display_cop_names: args.display_cop_names? }
if only_cops if only_cops
options[:only_cops] = only_cops options[:only_cops] = only_cops
elsif except_cops elsif except_cops

4
Library/Homebrew/style.rb
View File

@ -16,7 +16,7 @@ module Homebrew
check_style_impl(files, :json, **options) check_style_impl(files, :json, **options)
end end
def check_style_impl(files, output_type, fix: false, except_cops: nil, only_cops: nil) def check_style_impl(files, output_type, fix: false, except_cops: nil, only_cops: nil, display_cop_names: false)
Homebrew.install_bundler_gems! Homebrew.install_bundler_gems!
require "rubocop" require "rubocop"
require "rubocops" require "rubocops"
@ -78,7 +78,7 @@ module Homebrew
case output_type case output_type
when :print when :print
args << "--debug" if Homebrew.args.debug? args << "--debug" if Homebrew.args.debug?
args << "--display-cop-names" if Homebrew.args.display_cop_names? args << "--display-cop-names" if display_cop_names
args << "--format" << "simple" if files.present? args << "--format" << "simple" if files.present?
system(cache_env, "rubocop", *args) system(cache_env, "rubocop", *args)
rubocop_success = $CHILD_STATUS.success? rubocop_success = $CHILD_STATUS.success?