admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Remove some evals from formula DSL

Browse Source 
The default arguments were removed from these methods long ago, so
nothing is standing in the way of using define_method here.
This commit is contained in:
Jack Nagel 2014-05-27 21:02:00 -05:00
parent 152490b7b0
commit 28fa5b0261
2 changed files with 4 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/Homebrew/formula.rb
View File

@ -633,12 +633,8 @@ class Formula
stable.mirror(val) stable.mirror(val)
end end
Checksum::TYPES.each do |cksum| Checksum::TYPES.each do |type|
class_eval <<-EOS, __FILE__, __LINE__ + 1 define_method(type) { |val| stable.send(type, val) }
def #{cksum}(val)
stable.#{cksum}(val)
end
EOS
end end
def bottle *, &block def bottle *, &block

8
Library/Homebrew/resource.rb
View File

@ -95,12 +95,8 @@ class Resource
puts "For your reference the SHA1 is: #{fn.sha1}" puts "For your reference the SHA1 is: #{fn.sha1}"
end end
Checksum::TYPES.each do |cksum| Checksum::TYPES.each do |type|
class_eval <<-EOS, __FILE__, __LINE__ + 1 define_method(type) { |val| @checksum = Checksum.new(type, val) }
def #{cksum}(val)
@checksum = Checksum.new(:#{cksum}, val)
end
EOS
end end
def url val=nil, specs={} def url val=nil, specs={}