admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

os/mac/sdk: typed: strict

Browse Source 
Signed-off-by: botantony <antonsm21@gmail.com>
This commit is contained in:
botantony 2025-09-09 15:07:54 +02:00
parent 289fed93b4
commit 28761d8756
No known key found for this signature in database
GPG Key ID: 7FE721557EA6AAD6
1 changed files with 15 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
Library/Homebrew/os/mac/sdk.rb
View File

@ -1,4 +1,4 @@
# typed: true # rubocop:todo Sorbet/StrictSigil # typed: strict
# frozen_string_literal: true # frozen_string_literal: true
require "system_command" require "system_command"
@ -22,7 +22,7 @@ module OS
sig { params(version: MacOSVersion, path: T.any(String, Pathname), source: Symbol).void } sig { params(version: MacOSVersion, path: T.any(String, Pathname), source: Symbol).void }
def initialize(version, path, source) def initialize(version, path, source)
@version = version @version = version
@path = Pathname.new(path) @path = T.let(Pathname.new(path), Pathname)
@source = source @source = source
end end
end end
@ -36,6 +36,11 @@ module OS
class NoSDKError < StandardError; end class NoSDKError < StandardError; end
sig { void }
def initialize
@all_sdks = T.let([], T::Array[SDK])
end
sig { params(version: MacOSVersion).returns(SDK) } sig { params(version: MacOSVersion).returns(SDK) }
def sdk_for(version) def sdk_for(version)
sdk = all_sdks.find { |s| s.version == version } sdk = all_sdks.find { |s| s.version == version }
@ -46,9 +51,7 @@ module OS
sig { returns(T::Array[SDK]) } sig { returns(T::Array[SDK]) }
def all_sdks def all_sdks
return @all_sdks if @all_sdks return @all_sdks unless @all_sdks.empty?
@all_sdks = []
# Bail out if there is no SDK prefix at all # Bail out if there is no SDK prefix at all
return @all_sdks unless File.directory? sdk_prefix return @all_sdks unless File.directory? sdk_prefix
@ -147,7 +150,7 @@ module OS
sig { override.returns(String) } sig { override.returns(String) }
def sdk_prefix def sdk_prefix
@sdk_prefix ||= begin @sdk_prefix ||= T.let(begin
# Xcode.prefix is pretty smart, so let's look inside to find the sdk # Xcode.prefix is pretty smart, so let's look inside to find the sdk
sdk_prefix = "#{Xcode.prefix}/Platforms/MacOSX.platform/Developer/SDKs" sdk_prefix = "#{Xcode.prefix}/Platforms/MacOSX.platform/Developer/SDKs"
# Finally query Xcode itself (this is slow, so check it last) # Finally query Xcode itself (this is slow, so check it last)
@ -155,7 +158,7 @@ module OS
sdk_prefix = File.join(sdk_platform_path, "Developer", "SDKs") unless File.directory? sdk_prefix sdk_prefix = File.join(sdk_platform_path, "Developer", "SDKs") unless File.directory? sdk_prefix
sdk_prefix sdk_prefix
end end, T.nilable(String))
end end
end end
@ -177,11 +180,11 @@ module OS
# return `nil` SDKs for Xcode 9 and older. # return `nil` SDKs for Xcode 9 and older.
sig { override.returns(String) } sig { override.returns(String) }
def sdk_prefix def sdk_prefix
@sdk_prefix ||= if CLT.provides_sdk? @sdk_prefix ||= T.let(if CLT.provides_sdk?
"#{CLT::PKG_PATH}/SDKs" "#{CLT::PKG_PATH}/SDKs"
else else
"" ""
end end, T.nilable(String))
end end
end end
end end