admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: fix false-positive for '--with-check' from 'depends_on "check" => :optional' (#188)

Browse Source 
Fixes #170
This commit is contained in:
Andrew Janke 2016-05-03 08:16:20 -04:00
parent 066489a2b3
commit 2805531f13
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/cmd/audit.rb
View File

@ -391,10 +391,12 @@ class FormulaAuditor
end end
if o.name =~ /^with(out)?-(?:checks?|tests)$/ if o.name =~ /^with(out)?-(?:checks?|tests)$/
unless formula.deps.any? { |d| d.name == "check" && (d.optional? || d.recommended?) }
problem "Use '--with#{$1}-test' instead of '--#{o.name}'. Migrate '--#{o.name}' with `deprecated_option`." problem "Use '--with#{$1}-test' instead of '--#{o.name}'. Migrate '--#{o.name}' with `deprecated_option`."
end end
end end
end end
end
def audit_desc def audit_desc
# For now, only check the description when using `--strict` # For now, only check the description when using `--strict`