From 278c06f31d909b3a5994c0845d6c0e8f95f792f7 Mon Sep 17 00:00:00 2001
From: FnControlOption <70830482+FnControlOption@users.noreply.github.com>
Date: Thu, 2 Sep 2021 08:23:07 -0700
Subject: [PATCH] upgrade: deduplicate cask caveats.

Cask::Installer.caveats invokes Homebrew.messages.record_caveats
so only invoke it once and store the return value.
---
 Library/Homebrew/cask/cmd/upgrade.rb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Library/Homebrew/cask/cmd/upgrade.rb b/Library/Homebrew/cask/cmd/upgrade.rb
index 3cf457bb29..e0c0aad719 100644
--- a/Library/Homebrew/cask/cmd/upgrade.rb
+++ b/Library/Homebrew/cask/cmd/upgrade.rb
@@ -203,7 +203,9 @@ module Cask
           # Start new cask's installation steps
           new_cask_installer.check_conflicts
 
-          puts new_cask_installer.caveats if new_cask_installer.caveats
+          if (caveats = new_cask_installer.caveats)
+            puts caveats
+          end
 
           new_cask_installer.fetch