upgrade: deduplicate cask caveats.

Cask::Installer.caveats invokes Homebrew.messages.record_caveats so only invoke it once and store the return value.
2021-09-02 08:23:07 -07:00 · 2021-09-02 08:23:07 -07:00 · 278c06f31d
commit 278c06f31d
parent 034d4ac82b
1 changed files with 3 additions and 1 deletions
--- a/Library/Homebrew/cask/cmd/upgrade.rb
+++ b/Library/Homebrew/cask/cmd/upgrade.rb
@ -203,7 +203,9 @@ module Cask
          # Start new cask's installation steps
          new_cask_installer.check_conflicts

-          puts new_cask_installer.caveats if new_cask_installer.caveats
+          if (caveats = new_cask_installer.caveats)
+            puts caveats
+          end

          new_cask_installer.fetch