From 2777369da798dad955d1dd03723425e8d105ebed Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Fri, 18 Dec 2020 14:55:59 +0000 Subject: [PATCH] formula_installer: exclude more from build-from-source warning. We should only complain when installing requested formulae that aren't currently installed. --- Library/Homebrew/formula_installer.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb index 5a3a38ff8e..e9722032f8 100644 --- a/Library/Homebrew/formula_installer.rb +++ b/Library/Homebrew/formula_installer.rb @@ -234,7 +234,8 @@ class FormulaInstaller if Homebrew.default_prefix? && !Homebrew::EnvConfig.developer? && !build_from_source? && !build_bottle? && - formula.tap&.core_tap? && !formula.bottle_unneeded? && + !installed_as_dependency? && + formula.tap&.core_tap? && !formula.bottle_unneeded? && !formula.any_version_installed? && # Integration tests override homebrew-core locations ENV["HOMEBREW_TEST_TMPDIR"].nil? && !pour_bottle? @@ -684,6 +685,7 @@ class FormulaInstaller # been done for us in `compute_dependencies` and there's no requirement to # fetch in a particular order. ignore_deps: true, + installed_as_dependency: true, include_test_formulae: @include_test_formulae, build_from_source_formulae: @build_from_source_formulae, keep_tmp: keep_tmp?,