admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

add audit for ENV.x11

Browse Source
This commit is contained in:
Adam Vandenberg 2012-09-03 19:18:58 -07:00
parent 33233f5039
commit 26f887d4ab
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/cmd/audit.rb
View File

@ -352,6 +352,10 @@ class FormulaAuditor
problem "xcodebuild should be passed an explicit \"SYMROOT\"" problem "xcodebuild should be passed an explicit \"SYMROOT\""
end end
if text =~ /ENV\.x11/
problem "Use \"depends_on :x11\" instead of \"ENV.x11\""
end
# Avoid hard-coding compilers # Avoid hard-coding compilers
if text =~ %r[(system|ENV\[.+\]\s?=)\s?['"](/usr/bin/)?(gcc|llvm-gcc|clang)['" ]] if text =~ %r[(system|ENV\[.+\]\s?=)\s?['"](/usr/bin/)?(gcc|llvm-gcc|clang)['" ]]
problem "Use \"\#{ENV.cc}\" instead of hard-coding \"#{$3}\"" problem "Use \"\#{ENV.cc}\" instead of hard-coding \"#{$3}\""