add audit for ENV.x11

2012-09-03 19:18:58 -07:00 · 2012-09-03 19:18:58 -07:00 · 26f887d4ab
commit 26f887d4ab
parent 33233f5039
1 changed files with 4 additions and 0 deletions
--- a/Library/Homebrew/cmd/audit.rb
+++ b/Library/Homebrew/cmd/audit.rb
@ -352,6 +352,10 @@ class FormulaAuditor
      problem "xcodebuild should be passed an explicit \"SYMROOT\""
    end

+    if text =~ /ENV\.x11/
+      problem "Use \"depends_on :x11\" instead of \"ENV.x11\""
+    end
+
    # Avoid hard-coding compilers
    if text =~ %r[(system|ENV\[.+\]\s?=)\s?['"](/usr/bin/)?(gcc|llvm-gcc|clang)['" ]]
      problem "Use \"\#{ENV.cc}\" instead of hard-coding \"#{$3}\""