From 26ea79e1e67886411c922d70efb69c9d1e967f06 Mon Sep 17 00:00:00 2001 From: Bob Lail Date: Tue, 11 Jan 2022 08:34:51 -0600 Subject: [PATCH] Increase Metrics/BlockLength limit instead of disabling the cop for the block in `install_args` --- Library/Homebrew/.rubocop.yml | 2 +- Library/Homebrew/cmd/install.rb | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/Library/Homebrew/.rubocop.yml b/Library/Homebrew/.rubocop.yml index 9f8b3cad11..8e9dde07fd 100644 --- a/Library/Homebrew/.rubocop.yml +++ b/Library/Homebrew/.rubocop.yml @@ -16,7 +16,7 @@ Lint/NestedMethodDefinition: Metrics/AbcSize: Max: 280 Metrics/BlockLength: - Max: 103 + Max: 106 Exclude: # TODO: extract more of the bottling logic - "dev-cmd/bottle.rb" diff --git a/Library/Homebrew/cmd/install.rb b/Library/Homebrew/cmd/install.rb index 56a1b0ed6f..ae56fc16d6 100644 --- a/Library/Homebrew/cmd/install.rb +++ b/Library/Homebrew/cmd/install.rb @@ -22,7 +22,6 @@ module Homebrew sig { returns(CLI::Parser) } def install_args - # rubocop:disable Metrics/BlockLength Homebrew::CLI::Parser.new do description <<~EOS Install a or . Additional options specific to a may be @@ -136,7 +135,6 @@ module Homebrew named_args [:formula, :cask], min: 1 end - # rubocop:enable Metrics/BlockLength end def install