admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Add audit check for system "xcodebuild"

Browse Source
This commit is contained in:
Jack Nagel 2014-02-27 21:47:38 -06:00
parent c72f9a469d
commit 26c71b19f6
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Library/Homebrew/cmd/audit.rb
View File

@ -296,8 +296,12 @@ class FormulaAuditor
problem "use \"scons *args\" instead of \"system 'scons', *args\""
end
if text =~ /system\s+['"]xcodebuild/ && text !~ /SYMROOT=/
problem "xcodebuild should be passed an explicit \"SYMROOT\""
if text =~ /system\s+['"]xcodebuild/
problem %{use "xcodebuild *args" instead of "system 'xcodebuild', *args"}
end
if text =~ /xcodebuild[ (]["'*]/ && text !~ /SYMROOT=/
problem %{xcodebuild should be passed an explicit "SYMROOT"}
end
if text =~ /Formula\.factory\(/