From 269405995eafbeb7c114e297521cae05a754ac5c Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Sun, 7 Sep 2014 14:20:37 -0500 Subject: [PATCH] Simplify getting the list of doctor checks --- Library/Homebrew/cmd/doctor.rb | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/Library/Homebrew/cmd/doctor.rb b/Library/Homebrew/cmd/doctor.rb index 20e00f7eb5..1dbe401919 100644 --- a/Library/Homebrew/cmd/doctor.rb +++ b/Library/Homebrew/cmd/doctor.rb @@ -1109,6 +1109,10 @@ end EOS end end + + def all + methods.map(&:to_s).grep(/^check_/) + end end # end class Checks module Homebrew @@ -1116,18 +1120,19 @@ module Homebrew checks = Checks.new if ARGV.include? '--list-checks' - puts checks.methods.grep(/^check_/).sort + puts checks.all.sort exit end inject_dump_stats(checks) if ARGV.switch? 'D' - methods = if ARGV.named.empty? - # put slowest methods last - checks.methods.map(&:to_s).sort << "check_for_linked_keg_only_brews" << "check_for_outdated_homebrew" + if ARGV.named.empty? + methods = checks.all.sort + methods << "check_for_linked_keg_only_brews" << "check_for_outdated_homebrew" + methods = methods.reverse.uniq.reverse else - ARGV.named - end.grep(/^check_/).reverse.uniq.reverse + methods = ARGV.named + end first_warning = true methods.each do |method|