From 25b9a7d35bb5a4615df2509f3f29c2542c0c574d Mon Sep 17 00:00:00 2001 From: Jan Viljanen <527069+javian@users.noreply.github.com> Date: Thu, 27 Sep 2018 04:33:11 +0200 Subject: [PATCH] rubocop: move requirement to configuration file If you are using en external rubocop binary you will encounter the following error. .rubocop_todo.yml: RSpec/FilePath has the wrong namespace - should be Rails By moving the option to the config file an external rubocop would be treated equally to brew style without having to supply additional command line options. --- Library/.rubocop.yml | 4 +++- Library/Homebrew/style.rb | 1 - 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Library/.rubocop.yml b/Library/.rubocop.yml index 67b37c111c..2ca6bc1722 100644 --- a/Library/.rubocop.yml +++ b/Library/.rubocop.yml @@ -5,7 +5,9 @@ AllCops: - '**/vendor/**/*' DisplayCopNames: false -require: ./Homebrew/rubocops.rb +require: + - rubocop-rspec + - ./Homebrew/rubocops.rb # enable all formulae audits FormulaAudit: diff --git a/Library/Homebrew/style.rb b/Library/Homebrew/style.rb index ca95138c05..7e7dedb498 100644 --- a/Library/Homebrew/style.rb +++ b/Library/Homebrew/style.rb @@ -23,7 +23,6 @@ module Homebrew require "rubocops" args = %w[ - --require rubocop-rspec --force-exclusion ] if fix