admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Enable RSpec/LeakyConstantDeclaration

Browse Source
This commit is contained in:
Douglas Eichelberger 2023-01-24 20:07:22 -08:00
parent 1c85a717cc
commit 259e4ae718
4 changed files with 20 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/.rubocop_rspec.yml
View File

@ -11,8 +11,6 @@ RSpec/SubjectStub:
# TODO: try to enable these # TODO: try to enable these
RSpec/DescribeClass: RSpec/DescribeClass:
Enabled: false Enabled: false
RSpec/LeakyConstantDeclaration:
Enabled: false
RSpec/MessageSpies: RSpec/MessageSpies:
Enabled: false Enabled: false
RSpec/StubbedMock: RSpec/StubbedMock:

3
Library/Homebrew/test/exceptions_spec.rb
View File

@ -89,9 +89,12 @@ describe "Exception" do
let(:mod) do let(:mod) do
Module.new do Module.new do
# These are defined within an anonymous module to avoid polluting the global namespace.
# rubocop:disable RSpec/LeakyConstantDeclaration
class Bar < Requirement; end class Bar < Requirement; end
class Baz < Formula; end class Baz < Formula; end
# rubocop:enable RSpec/LeakyConstantDeclaration
end end
end end

13
Library/Homebrew/test/formula_free_port_spec.rb
View File

@ -9,16 +9,15 @@ module Homebrew
include described_class include described_class
describe "#free_port" do describe "#free_port" do
# IANA suggests user port from 1024 to 49151
# and dynamic port for 49152 to 65535
# http://www.iana.org/assignments/port-numbers
MIN_PORT = 1024
MAX_PORT = 65535
it "returns a free TCP/IP port" do it "returns a free TCP/IP port" do
# IANA suggests user port from 1024 to 49151
# and dynamic port for 49152 to 65535
# http://www.iana.org/assignments/port-numbers
min_port = 1024
max_port = 65535
port = free_port port = free_port
expect(port).to be_between(MIN_PORT, MAX_PORT) expect(port).to be_between(min_port, max_port)
expect { TCPServer.new(port).close }.not_to raise_error expect { TCPServer.new(port).close }.not_to raise_error
end end
end end

20
Library/Homebrew/test/patching_spec.rb
View File

@ -4,15 +4,17 @@
require "formula" require "formula"
describe "patching" do describe "patching" do
TESTBALL_URL = "file://#{TEST_FIXTURE_DIR}/tarballs/testball-0.1.tbz" before do
TESTBALL_PATCHES_URL = "file://#{TEST_FIXTURE_DIR}/tarballs/testball-0.1-patches.tgz" stub_const("TESTBALL_URL", "file://#{TEST_FIXTURE_DIR}/tarballs/testball-0.1.tbz")
PATCH_URL_A = "file://#{TEST_FIXTURE_DIR}/patches/noop-a.diff" stub_const("TESTBALL_PATCHES_URL", "file://#{TEST_FIXTURE_DIR}/tarballs/testball-0.1-patches.tgz")
PATCH_URL_B = "file://#{TEST_FIXTURE_DIR}/patches/noop-b.diff" stub_const("PATCH_URL_A", "file://#{TEST_FIXTURE_DIR}/patches/noop-a.diff")
PATCH_A_CONTENTS = File.read("#{TEST_FIXTURE_DIR}/patches/noop-a.diff").freeze stub_const("PATCH_URL_B", "file://#{TEST_FIXTURE_DIR}/patches/noop-b.diff")
PATCH_B_CONTENTS = File.read("#{TEST_FIXTURE_DIR}/patches/noop-b.diff").freeze stub_const("PATCH_A_CONTENTS", File.read("#{TEST_FIXTURE_DIR}/patches/noop-a.diff").freeze)
APPLY_A = "noop-a.diff" stub_const("PATCH_B_CONTENTS", File.read("#{TEST_FIXTURE_DIR}/patches/noop-b.diff").freeze)
APPLY_B = "noop-b.diff" stub_const("APPLY_A", "noop-a.diff")
APPLY_C = "noop-c.diff" stub_const("APPLY_B", "noop-b.diff")
stub_const("APPLY_C", "noop-c.diff")
end
def formula(name = "formula_name", path: Formulary.core_path(name), spec: :stable, alias_path: nil, &block) def formula(name = "formula_name", path: Formulary.core_path(name), spec: :stable, alias_path: nil, &block)
Class.new(Formula) { Class.new(Formula) {