admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Sparkle: Handle ArgumentError from Time#parse

Browse Source
This commit is contained in:
Sam Ford 2021-06-22 09:55:22 -04:00
parent a5768de0c3
commit 23f8cb9f4a
No known key found for this signature in database
GPG Key ID: 95209E46C7FFDEFE
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Library/Homebrew/livecheck/strategy/sparkle.rb
View File

@ -75,7 +75,12 @@ module Homebrew
version ||= (item > "version").first&.text&.strip
title = (item > "title").first&.text&.strip
pub_date = (item > "pubDate").first&.text&.strip&.presence&.yield_self { |d| Time.parse(d) }
pub_date = (item > "pubDate").first&.text&.strip&.presence&.yield_self do |date_string|
Time.parse(date_string)
rescue ArgumentError
# Omit unparseable strings (e.g. non-English dates)
nil
end
if (match = title&.match(/(\d+(?:\.\d+)*)\s*(\([^)]+\))?\Z/))
short_version ||= match[1]