admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: correct inverted has_trailing_newline condition

Browse Source 
has_trailing_newline? checked if formula did not have a trailing
newline. Invert regex and invert audit check.

Closes Homebrew/homebrew#18359.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This commit is contained in:
Tobias Lidskog 2013-02-21 09:56:30 +01:00 committed by Jack Nagel
parent 04dfdd972c
commit 23575f3c7f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Library/Homebrew/cmd/audit.rb
View File

@ -68,7 +68,7 @@ class FormulaText
end end
def has_trailing_newline? def has_trailing_newline?
/.+\z/ =~ @text /\Z\n/ =~ @text
end end
end end
@ -112,7 +112,7 @@ class FormulaAuditor
problem "'__END__' was found, but 'DATA' is not used" problem "'__END__' was found, but 'DATA' is not used"
end end
if f.text.has_trailing_newline? unless f.text.has_trailing_newline?
problem "File should end with a newline" problem "File should end with a newline"
end end
end end