Improve checksum perf by providing an output buffer

2013-08-13 15:40:48 -05:00 · 2013-08-13 15:40:48 -05:00 · 22365f2f6d
commit 22365f2f6d
parent f960cf94d1
1 changed files with 2 additions and 5 deletions
--- a/Library/Homebrew/extend/pathname.rb
+++ b/Library/Homebrew/extend/pathname.rb
@ -211,11 +211,8 @@ class Pathname

  def incremental_hash(hasher)
    incr_hash = hasher.new
-    self.open('r') do |f|
-      while(buf = f.read(1024))
-        incr_hash << buf
-      end
-    end
+    buf = ""
+    open('r') { |f| incr_hash << buf while f.read(1024, buf) }
    incr_hash.hexdigest
  end