From a09169f248de707bf8121acfb6c5d5c2b92c58de Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Mon, 13 Feb 2017 15:49:33 +0100 Subject: [PATCH 1/3] audit: enforce https for *.sourceforge.io urls --- Library/Homebrew/dev-cmd/audit.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index 0522c7878f..3447633eb4 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -584,7 +584,9 @@ class FormulaAuditor # People will run into mixed content sometimes, but we should enforce and then add # exemptions as they are discovered. Treat mixed content on homepages as a bug. # Justify each exemptions with a code comment so we can keep track here. - if homepage =~ %r{^http://[^/]*github\.io/} + case homepage + when %r{^http://[^/]*github\.io/}, + %r{^http://[^/]*\.sourceforge\.io/} problem "Please use https:// for #{homepage}" end From 64448834a68ee1e183e5c2bf9504dadfa9431dc1 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Mon, 13 Feb 2017 16:20:34 +0000 Subject: [PATCH 2/3] fix existing rule for github.io homepages --- Library/Homebrew/dev-cmd/audit.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/dev-cmd/audit.rb b/Library/Homebrew/dev-cmd/audit.rb index 3447633eb4..6aeb187499 100644 --- a/Library/Homebrew/dev-cmd/audit.rb +++ b/Library/Homebrew/dev-cmd/audit.rb @@ -585,7 +585,7 @@ class FormulaAuditor # exemptions as they are discovered. Treat mixed content on homepages as a bug. # Justify each exemptions with a code comment so we can keep track here. case homepage - when %r{^http://[^/]*github\.io/}, + when %r{^http://[^/]*\.github\.io/}, %r{^http://[^/]*\.sourceforge\.io/} problem "Please use https:// for #{homepage}" end From bf314fb08250cffa9bacb164b59b463f598da571 Mon Sep 17 00:00:00 2001 From: Viktor Szakats Date: Tue, 14 Feb 2017 18:46:48 +0000 Subject: [PATCH 3/3] add test --- Library/Homebrew/test/audit_test.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/Library/Homebrew/test/audit_test.rb b/Library/Homebrew/test/audit_test.rb index b1ccb1e103..9165edef1e 100644 --- a/Library/Homebrew/test/audit_test.rb +++ b/Library/Homebrew/test/audit_test.rb @@ -434,6 +434,7 @@ class FormulaAuditorTests < Homebrew::TestCase "sf1" => "http://foo.sourceforge.net/", "sf2" => "http://foo.sourceforge.net", "sf3" => "http://foo.sf.net/", + "sf4" => "http://foo.sourceforge.io/", "waldo" => "http://www.gnu.org/waldo", }