admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Close read pipe immediately after reading and only when initialized

Browse Source 
c.f. Homebrew/homebrew#22386.
This commit is contained in:
Jack Nagel 2013-09-07 22:17:52 -05:00
parent 4eb31ac676
commit 20ed26c655
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Library/Homebrew/formula_installer.rb
View File

@ -417,6 +417,7 @@ class FormulaInstaller
write.close write.close
Process.wait Process.wait
data = read.read data = read.read
read.close
raise Marshal.load(data) unless data.nil? or data.empty? raise Marshal.load(data) unless data.nil? or data.empty?
raise Interrupt if $?.exitstatus == 130 raise Interrupt if $?.exitstatus == 130
raise "Suspicious installation failure" unless $?.success? raise "Suspicious installation failure" unless $?.success?
@ -431,8 +432,6 @@ class FormulaInstaller
f.rack.rmdir_if_possible f.rack.rmdir_if_possible
end end
raise raise
ensure
read.close
end end
def link def link