From 202f793d8a46bcc186740429af26ea14093d49f8 Mon Sep 17 00:00:00 2001 From: Dominyk Tiller Date: Sun, 31 Jul 2016 02:00:33 +0100 Subject: [PATCH] cleaner: kill unnecessary perl elements We shouldn't be packaging either `perllocal.pod` or `.packlist` files. Both are only really useful outside of package management. They get automatically generated whenever you install a Perl module. Debian, Arch, MacPorts & others remove them and we should have been as well really; keeping them causes completely unnecessary conflicts between formulae. --- Library/Homebrew/cleaner.rb | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/Library/Homebrew/cleaner.rb b/Library/Homebrew/cleaner.rb index e20d1b7e64..d8a9985766 100644 --- a/Library/Homebrew/cleaner.rb +++ b/Library/Homebrew/cleaner.rb @@ -1,6 +1,8 @@ # Cleans a newly installed keg. # By default: # * removes .la files +# * removes perllocal.pod files +# * removes .packlist files # * removes empty directories # * sets permissions on executables # * removes unresolved symlinks @@ -89,6 +91,14 @@ class Cleaner next elsif path.extname == ".la" path.unlink + elsif path.basename.to_s == "perllocal.pod" + # Both this file & the .packlist one below are completely unnecessary + # to package & causes pointless conflict with other formulae. They are + # removed by Debian, Arch & MacPorts amongst other packagers as well. + # The files are created as part of installing any Perl module. + path.unlink + elsif path.basename.to_s == ".packlist" # Hidden file, not file extension! + path.unlink else # Set permissions for executables and non-executables perms = if executable_path?(path)