admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

rubocops/lines: allow OS.foo? in service blocks

Browse Source 
These seem more natural, and I don't think we need to be able to mock
service blocks on other OSs.

See Homebrew/homebrew-core#90091.
This commit is contained in:
Carlo Cabrera 2021-11-28 21:47:21 +08:00
parent 4c3f325347
commit 1ffbcc04d4
No known key found for this signature in database
GPG Key ID: C74D447FC549A1D0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/rubocops/lines.rb
View File

@ -354,7 +354,7 @@ module RuboCop
def audit_formula(_node, _class_node, _parent_class_node, body_node) def audit_formula(_node, _class_node, _parent_class_node, body_node)
no_on_os_method_names = [:install, :post_install].freeze no_on_os_method_names = [:install, :post_install].freeze
no_on_os_block_names = [:test].freeze no_on_os_block_names = [:service, :test].freeze
[[:on_macos, :mac?], [:on_linux, :linux?]].each do |on_method_name, if_method_name| [[:on_macos, :mac?], [:on_linux, :linux?]].each do |on_method_name, if_method_name|
if_method_and_class = "if OS.#{if_method_name}" if_method_and_class = "if OS.#{if_method_name}"
no_on_os_method_names.each do |formula_method_name| no_on_os_method_names.each do |formula_method_name|