From 1da81c675f8e53eb30d11ed9c9b98eb0bb1c4ba5 Mon Sep 17 00:00:00 2001 From: Issy Long Date: Thu, 19 Mar 2020 19:17:26 +0000 Subject: [PATCH] actions/tests: Run `brew style` and `brew man` before `brew tests` - The style and man page checks are quicker than `brew tests`, which can take forever. - If people make mistakes with style or forget to run `brew man`, they will notice quicker, thus fixing issues quicker. - This also wastes less compute time (and therefore energy) by only running `brew tests` when all the other less-involved checks work. --- .github/workflows/tests.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 9785ecfe05..4bf4f9bec7 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -78,6 +78,12 @@ jobs: sudo chmod -R g-w,o-w /home/linuxbrew /home/runner /opt fi + - name: Run brew style + run: brew style --display-cop-names + + - name: Run brew man + run: brew man --fail-if-changed + - name: Run brew tests run: | # brew tests doesn't like world writable directories @@ -107,12 +113,6 @@ jobs: # These cannot be queried at the macOS level on GitHub Actions. HOMEBREW_LANGUAGES: en-GB - - name: Run brew style - run: brew style --display-cop-names - - - name: Run brew man - run: brew man --fail-if-changed - - name: Run brew update-tests run: | git config --global user.name "BrewTestBot"