admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

rubocops/patches: remove autocorrection of some URLs

Browse Source
This commit is contained in:
Nanda H Krishna 2021-04-17 01:44:28 +05:30
parent 5c352437d9
commit 1c2d76c4e4
No known key found for this signature in database
GPG Key ID: 067E5FCD58ADF3AA
1 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Library/Homebrew/rubocops/patches.rb
View File

@ -53,24 +53,16 @@ module RuboCop
end
if regex_match_group(patch_url_node, %r{https://github.com/[^/]*/[^/]*/commit/[a-fA-F0-9]*\.diff})
problem "GitHub patches should end with .patch, not .diff: #{patch_url}" do |corrector|
correct = patch_url_node.source.gsub(/\.diff/, ".patch")
corrector.replace(patch_url_node.source_range, correct)
end
problem "GitHub patches should end with .patch, not .diff: #{patch_url}"
end
if regex_match_group(patch_url_node, %r{.*gitlab.*/commit/[a-fA-F0-9]*\.diff})
problem "GitLab patches should end with .patch, not .diff: #{patch_url}" do |corrector|
correct = patch_url_node.source.gsub(/\.diff/, ".patch")
corrector.replace(patch_url_node.source_range, correct)
end
problem "GitLab patches should end with .patch, not .diff: #{patch_url}"
end
gh_patch_param_pattern = %r{https?://github\.com/.+/.+/(?:commit|pull)/[a-fA-F0-9]*.(?:patch|diff)}
if regex_match_group(patch_url_node, gh_patch_param_pattern) && !patch_url.match?(/\?full_index=\w+$/)
problem "GitHub patches should use the full_index parameter: #{patch_url}?full_index=1" do |corrector|
corrector.replace(patch_url_node.source_range, "\"#{patch_url}?full_index=1\"")
end
problem "GitHub patches should use the full_index parameter: #{patch_url}?full_index=1"
end
gh_patch_patterns = Regexp.union([%r{/raw\.github\.com/},