From 1c176348caf6f6d220a1f877433a3ea581ab3030 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Tue, 17 Jun 2014 14:25:43 +0100 Subject: [PATCH] doctor: add caveats to avoid scaring people. Sporadically people ask to whitelist doctor warnings or file issues when there's nothing actually wrong. Help reassure such people with a friendly message. Closes Homebrew/homebrew#30230. Signed-off-by: Mike McQuaid --- Library/Homebrew/cmd/doctor.rb | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/cmd/doctor.rb b/Library/Homebrew/cmd/doctor.rb index b00ea583d5..eaf380c59d 100644 --- a/Library/Homebrew/cmd/doctor.rb +++ b/Library/Homebrew/cmd/doctor.rb @@ -1130,8 +1130,16 @@ module Homebrew methods.each do |method| out = checks.send(method) unless out.nil? or out.empty? + if first_warning + puts <<-EOS.undent + #{Tty.white}Please note that these warnings are just used to help the Homebrew maintainers + with debugging if you file an issue. If everything you use Homebrew for is + working fine: please don't worry and just ignore them. Thanks!#{Tty.reset} + EOS + end + lines = out.to_s.split('\n') - puts unless first_warning + puts opoo lines.shift Homebrew.failed = true puts lines