admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Launchpad: Use DEFAULT_REGEX as default regex arg

Browse Source 
Using `DEFAULT_REGEX` as the default value of the `#find_versions`
`regex` parameter allows us to tighten the type.
This commit is contained in:
Sam Ford 2023-04-28 23:24:34 -04:00
parent a28e1aa422
commit 1c03018b6a
No known key found for this signature in database
GPG Key ID: 7AF5CBEE1DD6F76D
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Library/Homebrew/livecheck/strategy/launchpad.rb
View File

@ -71,15 +71,15 @@ module Homebrew
sig { sig {
params( params(
url: String, url: String,
regex: T.nilable(Regexp), regex: Regexp,
unused: T.nilable(T::Hash[Symbol, T.untyped]), unused: T.nilable(T::Hash[Symbol, T.untyped]),
block: T.nilable(Proc), block: T.nilable(Proc),
).returns(T::Hash[Symbol, T.untyped]) ).returns(T::Hash[Symbol, T.untyped])
} }
def self.find_versions(url:, regex: nil, **unused, &block) def self.find_versions(url:, regex: DEFAULT_REGEX, **unused, &block)
generated = generate_input_values(url) generated = generate_input_values(url)
PageMatch.find_versions(url: generated[:url], regex: regex || DEFAULT_REGEX, **unused, &block) PageMatch.find_versions(url: generated[:url], regex: regex, **unused, &block)
end end
end end
end end