From 19cf6dcb3f35ca475a5b96a56913aabb05e9918d Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Tue, 20 Jun 2017 15:27:16 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A8=20=20Fix=20sorting=20on=20APFS.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Library/Homebrew/cmd/switch.rb | 2 +- Library/Homebrew/formula.rb | 4 ++-- Library/Homebrew/test/formula_pin_spec.rb | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Library/Homebrew/cmd/switch.rb b/Library/Homebrew/cmd/switch.rb index a40b4d88e7..8a378aed79 100644 --- a/Library/Homebrew/cmd/switch.rb +++ b/Library/Homebrew/cmd/switch.rb @@ -28,7 +28,7 @@ module Homebrew unless (rack/version).directory? onoe "#{name} does not have a version \"#{version}\" in the Cellar." - versions = rack.subdirs.map { |d| Keg.new(d).version } + versions = rack.subdirs.map { |d| Keg.new(d).version }.sort puts "Versions available: #{versions.join(", ")}" exit 3 diff --git a/Library/Homebrew/formula.rb b/Library/Homebrew/formula.rb index d64191b66b..66993a348b 100644 --- a/Library/Homebrew/formula.rb +++ b/Library/Homebrew/formula.rb @@ -602,7 +602,7 @@ class Formula # All currently installed prefix directories. # @private def installed_prefixes - rack.directory? ? rack.subdirs : [] + rack.directory? ? rack.subdirs.sort : [] end # All currently installed kegs. @@ -1182,7 +1182,7 @@ class Formula return false unless old_rack.directory? return false if old_rack.subdirs.empty? - tap == Tab.for_keg(old_rack.subdirs.first).tap + tap == Tab.for_keg(old_rack.subdirs.sort.first).tap end # @private diff --git a/Library/Homebrew/test/formula_pin_spec.rb b/Library/Homebrew/test/formula_pin_spec.rb index 909bfbc2b3..ce952a9574 100644 --- a/Library/Homebrew/test/formula_pin_spec.rb +++ b/Library/Homebrew/test/formula_pin_spec.rb @@ -9,7 +9,7 @@ describe FormulaPin do formula.rack.mkpath allow(formula).to receive(:installed_prefixes) do - formula.rack.directory? ? formula.rack.subdirs : [] + formula.rack.directory? ? formula.rack.subdirs.sort : [] end allow(formula).to receive(:installed_kegs) do