From 192e6e052cd5e0ab47aa53e8b438640efedc3630 Mon Sep 17 00:00:00 2001 From: Jack Nagel Date: Thu, 6 Sep 2012 20:47:05 -0500 Subject: [PATCH] audit: allow some forms of gist patches The problem is not the raw URLs, but URLs that do not contain the commit hash corresponding to a particular version of the gist. Signed-off-by: Jack Nagel --- Library/Homebrew/cmd/audit.rb | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Library/Homebrew/cmd/audit.rb b/Library/Homebrew/cmd/audit.rb index 40060799ab..32eec75c87 100644 --- a/Library/Homebrew/cmd/audit.rb +++ b/Library/Homebrew/cmd/audit.rb @@ -253,7 +253,9 @@ class FormulaAuditor Patches.new(f.patches).select { |p| p.external? }.each do |p| case p.url when %r[raw\.github\.com], %r[gist\.github\.com/raw] - problem "Using raw GitHub URLs is not recommended:\n#{p.url}" + unless p.url =~ /[a-fA-F0-9]{40}/ + problem "GitHub/Gist patches should specify a revision:\n#{p.url}" + end when %r[macports/trunk] problem "MacPorts patches should specify a revision instead of trunk:\n#{p.url}" end