admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Merge pull request #18843 from Homebrew/formula_auditor-pkgconf-coretap

Browse Source 
formula_auditor: avoid `pkg-config` dependency in core tap
This commit is contained in:
Ruoyu Zhong 2024-12-03 10:59:05 +08:00 committed by GitHub
commit 18f5f85232
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Library/Homebrew/formula_auditor.rb
View File

@ -363,8 +363,7 @@ module Homebrew
# we want to allow uses_from_macos for aliases but not bare dependencies. # we want to allow uses_from_macos for aliases but not bare dependencies.
# we also allow `pkg-config` for backwards compatibility in external taps. # we also allow `pkg-config` for backwards compatibility in external taps.
# TODO: after migrating all `pkg-config` usage to `pkgconf`, do not allow `pkg-config` in core tap if self.class.aliases.include?(dep.name) && !dep.uses_from_macos? && (dep.name != "pkg-config" || @core_tap)
if self.class.aliases.include?(dep.name) && !dep.uses_from_macos? && dep.name != "pkg-config"
problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'." problem "Dependency '#{dep.name}' is an alias; use the canonical name '#{dep.to_formula.full_name}'."
end end