From 18150d9629d3981d14b8ac7ef83a1a5678601164 Mon Sep 17 00:00:00 2001 From: Markus Reiter Date: Fri, 16 Feb 2024 10:22:10 +0100 Subject: [PATCH] Demonstrate flaky tests. --- Library/Homebrew/test/cask/cask_loader_spec.rb | 15 +++++++++++++++ Library/Homebrew/test/formulary_spec.rb | 15 +++++++++++++++ 2 files changed, 30 insertions(+) diff --git a/Library/Homebrew/test/cask/cask_loader_spec.rb b/Library/Homebrew/test/cask/cask_loader_spec.rb index ccaa8d16aa..ca2bb32441 100644 --- a/Library/Homebrew/test/cask/cask_loader_spec.rb +++ b/Library/Homebrew/test/cask/cask_loader_spec.rb @@ -104,6 +104,21 @@ describe Cask::CaskLoader, :cask do described_class.for("#{old_tap}/#{token}") end.to output(%r{Cask #{old_tap}/#{token} was renamed to #{token}\.}).to_stderr end + + context "when there is an infinite tap migration loop" do + before do + (default_tap.path/"tap_migrations.json").write({ + token => old_tap.name, + }.to_json) + default_tap.clear_cache + end + + it "stops recursing" do + expect do + described_class.for("#{default_tap}/#{token}") + end.not_to output.to_stderr + end + end end end end diff --git a/Library/Homebrew/test/formulary_spec.rb b/Library/Homebrew/test/formulary_spec.rb index 86988f0533..e12a41d898 100644 --- a/Library/Homebrew/test/formulary_spec.rb +++ b/Library/Homebrew/test/formulary_spec.rb @@ -572,6 +572,21 @@ describe Formulary do described_class.loader_for("#{old_tap}/#{token}") end.to output(%r{Formula #{old_tap}/#{token} was renamed to #{token}\.}).to_stderr end + + context "when there is an infinite tap migration loop" do + before do + (default_tap.path/"tap_migrations.json").write({ + token => old_tap.name, + }.to_json) + default_tap.clear_cache + end + + it "stops recursing" do + expect do + described_class.loader_for("#{default_tap}/#{token}") + end.not_to output.to_stderr + end + end end end end