From 5921aef55c28587939af6b33beea3b9003e390f2 Mon Sep 17 00:00:00 2001 From: Bo Anderson Date: Tue, 2 May 2023 02:09:53 +0100 Subject: [PATCH] Fix DownloadError erroring itself --- Library/Homebrew/cask/download.rb | 10 +++++----- Library/Homebrew/downloadable.rb | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Library/Homebrew/cask/download.rb b/Library/Homebrew/cask/download.rb index f6c2f3ff5c..16fa062ecf 100644 --- a/Library/Homebrew/cask/download.rb +++ b/Library/Homebrew/cask/download.rb @@ -81,6 +81,11 @@ module Cask super end + sig { override.returns(String) } + def download_name + cask.token + end + private def quarantine(path) @@ -94,11 +99,6 @@ module Cask end end - sig { override.returns(String) } - def download_name - cask.token - end - sig { override.returns(T.nilable(::URL)) } def determine_url url diff --git a/Library/Homebrew/downloadable.rb b/Library/Homebrew/downloadable.rb index 76e34c29cf..143729d88a 100644 --- a/Library/Homebrew/downloadable.rb +++ b/Library/Homebrew/downloadable.rb @@ -109,13 +109,13 @@ class Downloadable EOS end - private - sig { overridable.returns(String) } def download_name File.basename(determine_url.to_s) end + private + sig { overridable.returns(T.nilable(URL)) } def determine_url @url