admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Markus Reiter <me@reitermark.us>
This commit is contained in:
Issy Long 2023-03-12 17:32:21 +00:00 committed by GitHub
parent 8862c33b62
commit 169ae0e155
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
Library/Homebrew/sorbet/custom_generators/env_config.rb
View File

@ -8,7 +8,7 @@ def nilable?(method)
%w[browser editor github_api_token].include?(method) %w[browser editor github_api_token].include?(method)
end end
File.open("#{File.dirname(__FILE__)}/../../env_config.rbi", "w") do |file| File.open("#{__dir__}/../../env_config.rbi", "w") do |file|
file.write(<<~RUBY) file.write(<<~RUBY)
# typed: strict # typed: strict
@ -23,15 +23,15 @@ File.open("#{File.dirname(__FILE__)}/../../env_config.rbi", "w") do |file|
dynamic_methods[name] = { default: hash[:default] } dynamic_methods[name] = { default: hash[:default] }
end end
methods = Homebrew::EnvConfig.methods(false).map(&:to_s).sort.select { |method| dynamic_methods.key?(method) } methods = Homebrew::EnvConfig.methods(false).map(&:to_s).select { |method| dynamic_methods.key?(method) }.sort
methods.each do |method| methods.each do |method|
return_type = if method.end_with?("?") return_type = if method.end_with?("?")
T::Boolean T::Boolean
elsif dynamic_methods[method][:default].instance_of?(Integer) elsif default = dynamic_methods[method][:default]
Integer default.class
else else
nilable?(method) ? T.nilable(String) : String T.nilable(String)
end end
file.write(<<-RUBY) file.write(<<-RUBY)
@ -39,8 +39,8 @@ File.open("#{File.dirname(__FILE__)}/../../env_config.rbi", "w") do |file|
def self.#{method}; end def self.#{method}; end
RUBY RUBY
file.write("\n") unless methods.last == method file.write("\n") unless method == methods.last
end end
file.write("end\n") file.puts "end"
end end