admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Version: kill silly class method

Browse Source 
Overriding <=> directly is much simpler.
This commit is contained in:
Jack Nagel 2013-02-06 22:25:02 -06:00
parent 7178210a71
commit 15562c8876
1 changed files with 9 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
Library/Homebrew/version.rb
View File

@ -188,13 +188,6 @@ class Version
m = /\.v(\d+[a-z]?)/.match(stem) m = /\.v(\d+[a-z]?)/.match(stem)
return m.captures.first unless m.nil? return m.captures.first unless m.nil?
end end
# DSL for defining comparators
class << self
def compare &blk
send(:define_method, '<=>', &blk)
end
end
end end
class VersionSchemeDetector class VersionSchemeDetector
@ -220,13 +213,14 @@ end
# Enable things like "MacOS.version >= :lion" # Enable things like "MacOS.version >= :lion"
class MacOSVersion < Version class MacOSVersion < Version
compare do |other| def <=>(other)
super Version.new case other v = case other
when :mountain_lion then 10.8 when :mountain_lion then 10.8
when :lion then 10.7 when :lion then 10.7
when :snow_leopard then 10.6 when :snow_leopard then 10.6
when :leopard then 10.5 when :leopard then 10.5
else other.to_s else other.to_s
end end
super(Version.new(v))
end end
end end