From 150e14f83da4d5c09649868888118d7976a79e2e Mon Sep 17 00:00:00 2001 From: Carlo Cabrera <30379873+carlocab@users.noreply.github.com> Date: Sun, 15 Sep 2024 18:51:06 +0800 Subject: [PATCH] cli/named_args: silence `package_conflicts_message` with `--quiet` Based on feedback from Homebrew/discussions#5602. While users can already silence this by passing `--formula` or `--cask` as required, I am inclined to agree that `--quiet` should probably silence messages that are relatively low priority (of which I think this is one). --- Library/Homebrew/cli/named_args.rb | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Library/Homebrew/cli/named_args.rb b/Library/Homebrew/cli/named_args.rb index 9eadc7f6ec..02785fce26 100644 --- a/Library/Homebrew/cli/named_args.rb +++ b/Library/Homebrew/cli/named_args.rb @@ -231,11 +231,13 @@ module Homebrew Failed to load cask: #{name} #{unreadable_error} EOS - opoo package_conflicts_message(name, "formula", cask) + opoo package_conflicts_message(name, "formula", cask) unless Context.current.quiet? end return formula_or_kegs elsif cask - opoo package_conflicts_message(name, "cask", formula_or_kegs) if formula_or_kegs + if formula_or_kegs && !Context.current.quiet? + opoo package_conflicts_message(name, "cask", formula_or_kegs) + end return cask end end @@ -519,6 +521,7 @@ module Homebrew nil end return unless available + return if Context.current.quiet? opoo package_conflicts_message(ref, loaded_type, cask) end