admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

How to Open A PR: clarify one commit per formula.

Browse Source
This commit is contained in:
Mike McQuaid 2015-05-15 09:35:36 +01:00
parent cf757b001d
commit 14981e6265
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
share/doc/homebrew/How-To-Open-a-Homebrew-Pull-Request-(and-get-it-merged).md
View File

@ -29,7 +29,7 @@ To make changes based on feedback:
1. Checkout your branch again with `git checkout YOUR_BRANCH_NAME` 1. Checkout your branch again with `git checkout YOUR_BRANCH_NAME`
2. Make any requested changes and commit them with `git add` and `git commit` 2. Make any requested changes and commit them with `git add` and `git commit`
3. Squash new commits into one change per formula with `git rebase --interactive origin/master` 3. Squash new commits into one commit per formula with `git rebase --interactive origin/master`
4. Push to the fork's remote branch and the pull request with `git push --force` 4. Push to the fork's remote branch and the pull request with `git push --force`
Once all feedback has been addressed and if it's a change we want to include (we include most changes) then we'll add your commit to Homebrew. Note it will not show up as "Merged" because of the way we include contributions. Once all feedback has been addressed and if it's a change we want to include (we include most changes) then we'll add your commit to Homebrew. Note it will not show up as "Merged" because of the way we include contributions.