admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

Eliminate chdir from pathname tests

Browse Source
This commit is contained in:
Jack Nagel 2015-03-25 21:37:26 -04:00
parent b49d3bd0a9
commit 148ebcb72e
1 changed files with 25 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
Library/Homebrew/test/test_pathname.rb
View File

@ -119,51 +119,46 @@ class PathnameInstallTests < PathnameExtensionTests
def setup_install_test def setup_install_test
(@src+'a.txt').write 'This is sample file a.' (@src+'a.txt').write 'This is sample file a.'
(@src+'b.txt').write 'This is sample file b.' (@src+'b.txt').write 'This is sample file b.'
cd(@src) { yield }
end end
def test_install def test_install
setup_install_test do setup_install_test
@dst.install 'a.txt' @dst.install @src+"a.txt"
end
assert_predicate @dst+"a.txt", :exist?, "a.txt was not installed" assert_predicate @dst+"a.txt", :exist?, "a.txt was not installed"
refute_predicate @dst+"b.txt", :exist?, "b.txt was installed." refute_predicate @dst+"b.txt", :exist?, "b.txt was installed."
end end
def test_install_list def test_install_list
setup_install_test do setup_install_test
@dst.install %w[a.txt b.txt] @dst.install [@src+"a.txt", @src+"b.txt"]
end
assert_predicate @dst+"a.txt", :exist?, "a.txt was not installed" assert_predicate @dst+"a.txt", :exist?, "a.txt was not installed"
assert_predicate @dst+"b.txt", :exist?, "b.txt was not installed" assert_predicate @dst+"b.txt", :exist?, "b.txt was not installed"
end end
def test_install_glob def test_install_glob
setup_install_test do setup_install_test
@dst.install Dir['*.txt'] @dst.install Dir[@src+"*.txt"]
end
assert_predicate @dst+"a.txt", :exist?, "a.txt was not installed" assert_predicate @dst+"a.txt", :exist?, "a.txt was not installed"
assert_predicate @dst+"b.txt", :exist?, "b.txt was not installed" assert_predicate @dst+"b.txt", :exist?, "b.txt was not installed"
end end
def test_install_directory def test_install_directory
setup_install_test do setup_install_test
mkdir_p 'bin' bin = @src+"bin"
mv Dir['*.txt'], 'bin' bin.mkpath
@dst.install 'bin' mv Dir[@src+"*.txt"], bin
end @dst.install bin
assert_predicate @dst+"bin/a.txt", :exist?, "a.txt was not installed" assert_predicate @dst+"bin/a.txt", :exist?, "a.txt was not installed"
assert_predicate @dst+"bin/b.txt", :exist?, "b.txt was not installed" assert_predicate @dst+"bin/b.txt", :exist?, "b.txt was not installed"
end end
def test_install_rename def test_install_rename
setup_install_test do setup_install_test
@dst.install 'a.txt' => 'c.txt' @dst.install @src+"a.txt" => "c.txt"
end
assert_predicate @dst+"c.txt", :exist?, "c.txt was not installed" assert_predicate @dst+"c.txt", :exist?, "c.txt was not installed"
refute_predicate @dst+"a.txt", :exist?, "a.txt was installed but not renamed" refute_predicate @dst+"a.txt", :exist?, "a.txt was installed but not renamed"
@ -171,9 +166,8 @@ class PathnameInstallTests < PathnameExtensionTests
end end
def test_install_rename_more def test_install_rename_more
setup_install_test do setup_install_test
@dst.install({'a.txt' => 'c.txt', 'b.txt' => 'd.txt'}) @dst.install(@src+"a.txt" => "c.txt", @src+"b.txt" => "d.txt")
end
assert_predicate @dst+"c.txt", :exist?, "c.txt was not installed" assert_predicate @dst+"c.txt", :exist?, "c.txt was not installed"
assert_predicate @dst+"d.txt", :exist?, "d.txt was not installed" assert_predicate @dst+"d.txt", :exist?, "d.txt was not installed"
@ -182,11 +176,11 @@ class PathnameInstallTests < PathnameExtensionTests
end end
def test_install_rename_directory def test_install_rename_directory
setup_install_test do setup_install_test
mkdir_p 'bin' bin = @src+"bin"
mv Dir['*.txt'], 'bin' bin.mkpath
@dst.install 'bin' => 'libexec' mv Dir[@src+"*.txt"], bin
end @dst.install bin => "libexec"
refute_predicate @dst+"bin", :exist?, "bin was installed but not renamed" refute_predicate @dst+"bin", :exist?, "bin was installed but not renamed"
assert_predicate @dst+"libexec/a.txt", :exist?, "a.txt was not installed" assert_predicate @dst+"libexec/a.txt", :exist?, "a.txt was not installed"
@ -194,12 +188,11 @@ class PathnameInstallTests < PathnameExtensionTests
end end
def test_install_symlink def test_install_symlink
setup_install_test do setup_install_test
mkdir_p 'bin' bin = @src+"bin"
mv Dir['*.txt'], 'bin' bin.mkpath
end mv Dir[@src+"*.txt"], bin
@dst.install_symlink bin
@dst.install_symlink @src+'bin'
assert_predicate @dst+"bin", :symlink? assert_predicate @dst+"bin", :symlink?
assert_predicate @dst+"bin", :directory? assert_predicate @dst+"bin", :directory?