From 1455d83dd8bb7b2a7fbd946eb4dd757c060b06a6 Mon Sep 17 00:00:00 2001 From: Mike McQuaid Date: Mon, 11 Aug 2014 20:15:25 +0100 Subject: [PATCH] formula_installer: check for recommended/optional. build.without? seemingly always returns true for requirements that are neither recommended nor optional so check these before deciding not to install a default formula. Closes Homebrew/homebrew#31511. --- Library/Homebrew/formula_installer.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Library/Homebrew/formula_installer.rb b/Library/Homebrew/formula_installer.rb index 2b064107b2..63b7fa0dfb 100644 --- a/Library/Homebrew/formula_installer.rb +++ b/Library/Homebrew/formula_installer.rb @@ -241,7 +241,7 @@ class FormulaInstaller def install_requirement_default_formula?(req, build) return false unless req.default_formula? - return false if build.without?(req) + return false if build.without?(req) && (req.recommended? || req.optional?) return true unless req.satisfied? pour_bottle? || build_bottle? end