Apply Mike's suggestions from code review
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
This commit is contained in:
parent
27a2dba340
commit
13735bc780
@ -53,7 +53,7 @@ homebrew-update-reset() {
|
|||||||
[[ -d "${DIR}/.git" ]] || continue
|
[[ -d "${DIR}/.git" ]] || continue
|
||||||
if ! git -C "${DIR}" config --local --get remote.origin.url &>/dev/null
|
if ! git -C "${DIR}" config --local --get remote.origin.url &>/dev/null
|
||||||
then
|
then
|
||||||
opoo "No remote 'origin' in: ${DIR}"
|
opoo "No remote 'origin' in ${DIR}, skipping update and reset!"
|
||||||
continue
|
continue
|
||||||
fi
|
fi
|
||||||
ohai "Fetching ${DIR}..."
|
ohai "Fetching ${DIR}..."
|
||||||
|
|||||||
@ -557,9 +557,10 @@ EOS
|
|||||||
|
|
||||||
if ! git config --local --get remote.origin.url &>/dev/null
|
if ! git config --local --get remote.origin.url &>/dev/null
|
||||||
then
|
then
|
||||||
opoo "No remote 'origin' in: ${DIR}"
|
opoo "No remote 'origin' in ${DIR}, skipping update!"
|
||||||
continue
|
continue
|
||||||
fi
|
fi
|
||||||
|
|
||||||
if [[ -n "${HOMEBREW_VERBOSE}" ]]
|
if [[ -n "${HOMEBREW_VERBOSE}" ]]
|
||||||
then
|
then
|
||||||
echo "Checking if we need to fetch ${DIR}..."
|
echo "Checking if we need to fetch ${DIR}..."
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user