admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

formulary: migrate fully-scoped formulae names.

Browse Source 
e.g. allow `brew install some/tap/formula` to look that formula up in
another tap if it has been migrated.

Also, add a deprecation message to point people towards the correct
naming.
This commit is contained in:
Mike McQuaid 2016-11-02 14:47:24 -04:00
parent ec527ff982
commit 133bad9a97
1 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
Library/Homebrew/formulary.rb
View File

@ -159,6 +159,11 @@ class Formulary
attr_reader :tap
def initialize(tapped_name)
name, path = formula_name_path(tapped_name)
super name, path
end
def formula_name_path(tapped_name, warn: true)
user, repo, name = tapped_name.split("/", 3).map(&:downcase)
@tap = Tap.fetch user, repo
formula_dir = @tap.formula_dir || @tap.path
@ -170,12 +175,25 @@ class Formulary
name = path.basename(".rb").to_s
elsif (new_name = @tap.formula_renames[name]) &&
(new_path = formula_dir/"#{new_name}.rb").file?
old_name = name
path = new_path
name = new_name
new_name = @tap.core_tap? ? name : "#{@tap}/#{name}"
elsif (new_tap_name = @tap.tap_migrations[name])
new_tap = Tap.fetch new_tap_name
new_tap.install unless new_tap.installed?
new_tapped_name = "#{new_tap_name}/#{name}"
name, path = formula_name_path(new_tapped_name, warn: false)
old_name = tapped_name
new_name = new_tap.core_tap? ? name : new_tapped_name
end
if warn && old_name && new_name
opoo "Use #{new_name} instead of deprecated #{old_name}"
end
end
super name, path
[name, path]
end
def get_formula(spec, alias_path: nil)