admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

audit: don't try to HTTP check non-HTTP content.

Browse Source
This commit is contained in:
Mike McQuaid 2017-02-24 08:51:15 +00:00
parent b984be675d
commit 1284f29561
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Library/Homebrew/dev-cmd/audit.rb
View File

@ -175,6 +175,8 @@ class FormulaAuditor
end end
def self.check_http_content(url, user_agents: [:default]) def self.check_http_content(url, user_agents: [:default])
return unless url.start_with? "http"
details = nil details = nil
user_agent = nil user_agent = nil
user_agents.each do |ua| user_agents.each do |ua|

5
Library/Homebrew/test/audit_test.rb
View File

@ -419,9 +419,8 @@ class FormulaAuditorTests < Homebrew::TestCase
EOS EOS
fa.audit_homepage fa.audit_homepage
assert_equal ["The homepage should start with http or https " \ assert_equal ["The homepage should start with http or https (URL is #{fa.formula.homepage})."],
"(URL is #{fa.formula.homepage}).", "The homepage #{fa.formula.homepage} is not reachable " \ fa.problems
"(HTTP status code 000)"], fa.problems
formula_homepages = { formula_homepages = {
"bar" => "http://www.freedesktop.org/wiki/bar", "bar" => "http://www.freedesktop.org/wiki/bar",