From 1248294c8cbdf2503eed3622d9e088ac75dec38e Mon Sep 17 00:00:00 2001 From: Xu Cheng Date: Mon, 26 Oct 2015 13:34:04 +0800 Subject: [PATCH] commands: ensure internal commands are files `Pathname#children(with_directory = false)` doesn't filter directories, instead it returns path with basename. Closes Homebrew/homebrew#45325. Signed-off-by: Xu Cheng --- Library/Homebrew/cmd/commands.rb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Library/Homebrew/cmd/commands.rb b/Library/Homebrew/cmd/commands.rb index d7734e1327..6630e71345 100644 --- a/Library/Homebrew/cmd/commands.rb +++ b/Library/Homebrew/cmd/commands.rb @@ -27,13 +27,11 @@ module Homebrew end def internal_commands - with_directory = false - (HOMEBREW_LIBRARY_PATH/"cmd").children(with_directory).map { |f| File.basename(f, ".rb") } + (HOMEBREW_LIBRARY_PATH/"cmd").children.select(&:file?).map { |f| f.basename(".rb").to_s } end def internal_development_commands - with_directory = false - (HOMEBREW_LIBRARY_PATH/"dev-cmd").children(with_directory).map { |f| File.basename(f, ".rb") } + (HOMEBREW_LIBRARY_PATH/"dev-cmd").children.select(&:file?).map { |f| f.basename(".rb").to_s } end def external_commands