admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

FormulaVersions: load from contents to reduce io

Browse Source
This commit is contained in:
Xu Cheng 2015-09-02 16:42:54 +08:00
parent 61c8f69c25
commit 11f0979dfb
1 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
Library/Homebrew/formula_versions.rb
View File

@ -7,12 +7,13 @@ class FormulaVersions
ErrorDuringExecution, LoadError ErrorDuringExecution, LoadError
] ]
attr_reader :name, :repository, :entry_name attr_reader :name, :path, :repository, :entry_name
def initialize(formula) def initialize(formula)
@name = formula.name @name = formula.name
@path = formula.path
@repository = formula.tap? ? HOMEBREW_LIBRARY.join("Taps", formula.tap) : HOMEBREW_REPOSITORY @repository = formula.tap? ? HOMEBREW_LIBRARY.join("Taps", formula.tap) : HOMEBREW_REPOSITORY
@entry_name = formula.path.relative_path_from(repository).to_s @entry_name = @path.relative_path_from(repository).to_s
end end
def rev_list(branch) def rev_list(branch)
@ -28,19 +29,16 @@ class FormulaVersions
end end
def formula_at_revision(rev) def formula_at_revision(rev)
FileUtils.mktemp(name) do contents = file_contents_at_revision(rev)
path = Pathname.pwd.join("#{name}.rb")
path.write file_contents_at_revision(rev)
begin begin
nostdout { yield Formulary.factory(path.to_s) } nostdout { yield Formulary.from_contents(name, path, contents) }
rescue *IGNORED_EXCEPTIONS => e rescue *IGNORED_EXCEPTIONS => e
# We rescue these so that we can skip bad versions and # We rescue these so that we can skip bad versions and
# continue walking the history # continue walking the history
ohai "#{e} in #{name} at revision #{rev}", e.backtrace if ARGV.debug? ohai "#{e} in #{name} at revision #{rev}", e.backtrace if ARGV.debug?
rescue FormulaUnavailableError rescue FormulaUnavailableError
# Suppress this error # Suppress this error
end
end end
end end