Remove byebug
since it doesn't work in tests anymore
- Byebug was introduced in [2020](https://github.com/Homebrew/brew/pull/7577) for hooking into tests for debugging. - It does not work anymore in so far as it does not stop at breakpoints when following the instructions to trigger them in tests.
This commit is contained in:
parent
929995c810
commit
11c1960729
@ -48,7 +48,6 @@ group :style, optional: true do
|
|||||||
gem "rubocop-sorbet", require: false
|
gem "rubocop-sorbet", require: false
|
||||||
end
|
end
|
||||||
group :tests, optional: true do
|
group :tests, optional: true do
|
||||||
gem "byebug", require: false
|
|
||||||
gem "parallel_tests", require: false
|
gem "parallel_tests", require: false
|
||||||
gem "rspec", require: false
|
gem "rspec", require: false
|
||||||
gem "rspec-github", require: false
|
gem "rspec-github", require: false
|
||||||
|
@ -7,7 +7,6 @@ GEM
|
|||||||
bindata (2.5.0)
|
bindata (2.5.0)
|
||||||
bootsnap (1.18.3)
|
bootsnap (1.18.3)
|
||||||
msgpack (~> 1.2)
|
msgpack (~> 1.2)
|
||||||
byebug (11.1.3)
|
|
||||||
coderay (1.1.3)
|
coderay (1.1.3)
|
||||||
commander (4.6.0)
|
commander (4.6.0)
|
||||||
highline (~> 2.0.0)
|
highline (~> 2.0.0)
|
||||||
@ -167,7 +166,6 @@ PLATFORMS
|
|||||||
DEPENDENCIES
|
DEPENDENCIES
|
||||||
addressable
|
addressable
|
||||||
bootsnap
|
bootsnap
|
||||||
byebug
|
|
||||||
json_schemer
|
json_schemer
|
||||||
kramdown
|
kramdown
|
||||||
method_source
|
method_source
|
||||||
|
@ -21,8 +21,6 @@ module Homebrew
|
|||||||
switch "--online",
|
switch "--online",
|
||||||
description: "Include tests that use the GitHub API and tests that use any of the taps for " \
|
description: "Include tests that use the GitHub API and tests that use any of the taps for " \
|
||||||
"official external commands."
|
"official external commands."
|
||||||
switch "--byebug",
|
|
||||||
description: "Enable debugging using byebug."
|
|
||||||
switch "--changed",
|
switch "--changed",
|
||||||
description: "Only runs tests on files that were changed from the master branch."
|
description: "Only runs tests on files that were changed from the master branch."
|
||||||
switch "--fail-fast",
|
switch "--fail-fast",
|
||||||
@ -45,8 +43,6 @@ module Homebrew
|
|||||||
# Given we might be testing various commands, we probably want everything (except sorbet-static)
|
# Given we might be testing various commands, we probably want everything (except sorbet-static)
|
||||||
Homebrew.install_bundler_gems!(groups: Homebrew.valid_gem_groups - ["sorbet"])
|
Homebrew.install_bundler_gems!(groups: Homebrew.valid_gem_groups - ["sorbet"])
|
||||||
|
|
||||||
require "byebug" if args.byebug?
|
|
||||||
|
|
||||||
HOMEBREW_LIBRARY_PATH.cd do
|
HOMEBREW_LIBRARY_PATH.cd do
|
||||||
setup_environment!
|
setup_environment!
|
||||||
|
|
||||||
|
@ -5,9 +5,6 @@
|
|||||||
# Please instead update this file by running `bin/tapioca dsl Homebrew::DevCmd::Tests`.
|
# Please instead update this file by running `bin/tapioca dsl Homebrew::DevCmd::Tests`.
|
||||||
|
|
||||||
class Homebrew::CLI::Args
|
class Homebrew::CLI::Args
|
||||||
sig { returns(T::Boolean) }
|
|
||||||
def byebug?; end
|
|
||||||
|
|
||||||
sig { returns(T::Boolean) }
|
sig { returns(T::Boolean) }
|
||||||
def changed?; end
|
def changed?; end
|
||||||
|
|
||||||
|
@ -6,7 +6,6 @@ gem:
|
|||||||
- json
|
- json
|
||||||
- msgpack
|
- msgpack
|
||||||
# These aren't needed:
|
# These aren't needed:
|
||||||
- byebug
|
|
||||||
- coderay
|
- coderay
|
||||||
- commander
|
- commander
|
||||||
- diff-lcs
|
- diff-lcs
|
||||||
|
@ -29,7 +29,6 @@ require "rspec/retry"
|
|||||||
require "rspec/sorbet"
|
require "rspec/sorbet"
|
||||||
require "rubocop/rspec/support"
|
require "rubocop/rspec/support"
|
||||||
require "find"
|
require "find"
|
||||||
require "byebug"
|
|
||||||
require "timeout"
|
require "timeout"
|
||||||
|
|
||||||
$LOAD_PATH.unshift(File.expand_path("#{ENV.fetch("HOMEBREW_LIBRARY")}/Homebrew/test/support/lib"))
|
$LOAD_PATH.unshift(File.expand_path("#{ENV.fetch("HOMEBREW_LIBRARY")}/Homebrew/test/support/lib"))
|
||||||
|
@ -35,8 +35,6 @@ $:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version
|
|||||||
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/msgpack-1.7.2/lib")
|
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/msgpack-1.7.2/lib")
|
||||||
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/extensions/arm64-darwin-20/#{Gem.extension_api_version}/bootsnap-1.18.3")
|
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/extensions/arm64-darwin-20/#{Gem.extension_api_version}/bootsnap-1.18.3")
|
||||||
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/bootsnap-1.18.3/lib")
|
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/bootsnap-1.18.3/lib")
|
||||||
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/extensions/arm64-darwin-20/#{Gem.extension_api_version}/byebug-11.1.3")
|
|
||||||
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/byebug-11.1.3/lib")
|
|
||||||
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/coderay-1.1.3/lib")
|
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/coderay-1.1.3/lib")
|
||||||
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/highline-2.0.3/lib")
|
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/highline-2.0.3/lib")
|
||||||
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/commander-4.6.0/lib")
|
$:.unshift File.expand_path("#{__dir__}/../#{RUBY_ENGINE}/#{Gem.ruby_api_version}/gems/commander-4.6.0/lib")
|
||||||
|
@ -2208,7 +2208,6 @@ _brew_tests() {
|
|||||||
case "${cur}" in
|
case "${cur}" in
|
||||||
-*)
|
-*)
|
||||||
__brewcomp "
|
__brewcomp "
|
||||||
--byebug
|
|
||||||
--changed
|
--changed
|
||||||
--coverage
|
--coverage
|
||||||
--debug
|
--debug
|
||||||
|
@ -1465,7 +1465,6 @@ __fish_brew_complete_arg 'test' -a '(__fish_brew_suggest_formulae_installed)'
|
|||||||
|
|
||||||
|
|
||||||
__fish_brew_complete_cmd 'tests' 'Run Homebrew\'s unit and integration tests'
|
__fish_brew_complete_cmd 'tests' 'Run Homebrew\'s unit and integration tests'
|
||||||
__fish_brew_complete_arg 'tests' -l byebug -d 'Enable debugging using byebug'
|
|
||||||
__fish_brew_complete_arg 'tests' -l changed -d 'Only runs tests on files that were changed from the master branch'
|
__fish_brew_complete_arg 'tests' -l changed -d 'Only runs tests on files that were changed from the master branch'
|
||||||
__fish_brew_complete_arg 'tests' -l coverage -d 'Generate code coverage reports'
|
__fish_brew_complete_arg 'tests' -l coverage -d 'Generate code coverage reports'
|
||||||
__fish_brew_complete_arg 'tests' -l debug -d 'Display any debugging information'
|
__fish_brew_complete_arg 'tests' -l debug -d 'Display any debugging information'
|
||||||
|
@ -1815,7 +1815,6 @@ _brew_test() {
|
|||||||
# brew tests
|
# brew tests
|
||||||
_brew_tests() {
|
_brew_tests() {
|
||||||
_arguments \
|
_arguments \
|
||||||
'--byebug[Enable debugging using byebug]' \
|
|
||||||
'(--only)--changed[Only runs tests on files that were changed from the master branch]' \
|
'(--only)--changed[Only runs tests on files that were changed from the master branch]' \
|
||||||
'--coverage[Generate code coverage reports]' \
|
'--coverage[Generate code coverage reports]' \
|
||||||
'--debug[Display any debugging information]' \
|
'--debug[Display any debugging information]' \
|
||||||
|
@ -2650,10 +2650,6 @@ Run Homebrew's unit and integration tests.
|
|||||||
: Include tests that use the GitHub API and tests that use any of the taps for
|
: Include tests that use the GitHub API and tests that use any of the taps for
|
||||||
official external commands.
|
official external commands.
|
||||||
|
|
||||||
`--byebug`
|
|
||||||
|
|
||||||
: Enable debugging using byebug.
|
|
||||||
|
|
||||||
`--changed`
|
`--changed`
|
||||||
|
|
||||||
: Only runs tests on files that were changed from the master branch.
|
: Only runs tests on files that were changed from the master branch.
|
||||||
|
@ -1687,9 +1687,6 @@ Run only OS\-agnostic tests\.
|
|||||||
\fB\-\-online\fP
|
\fB\-\-online\fP
|
||||||
Include tests that use the GitHub API and tests that use any of the taps for official external commands\.
|
Include tests that use the GitHub API and tests that use any of the taps for official external commands\.
|
||||||
.TP
|
.TP
|
||||||
\fB\-\-byebug\fP
|
|
||||||
Enable debugging using byebug\.
|
|
||||||
.TP
|
|
||||||
\fB\-\-changed\fP
|
\fB\-\-changed\fP
|
||||||
Only runs tests on files that were changed from the master branch\.
|
Only runs tests on files that were changed from the master branch\.
|
||||||
.TP
|
.TP
|
||||||
|
Loading…
x
Reference in New Issue
Block a user