admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity

try addressing style issues

Browse Source
This commit is contained in:
Viktor Szakats 2017-08-27 17:52:26 +00:00
parent 923c84d4f7
commit 11b267a7cf
1 changed files with 15 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
Library/Homebrew/dev-cmd/audit.rb
View File

@ -240,26 +240,25 @@ class FormulaAuditor
return "The URL #{url} could use HTTPS rather than HTTP" return "The URL #{url} could use HTTPS rather than HTTP"
end end
if type == "homepage" return if type != "homepage"
details[:file] = details[:file].gsub(/https?:\\?\/\\?\//, '/') details[:file] = details[:file].gsub(%r{https?:\\?\/\\?\/}, "/")
secure_details[:file] = secure_details[:file].gsub(/https?:\\?\/\\?\//, '/') secure_details[:file] = secure_details[:file].gsub(%r{https?:\\?\/\\?\/}, "/")
# Same content after normalization # Same content after normalization
if details[:file] == secure_details[:file] if details[:file] == secure_details[:file]
return "The URL #{url} could use HTTPS rather than HTTP" return "The URL #{url} could use HTTPS rather than HTTP"
end end
# Same size, different content after normalization # Same size, different content after normalization
# (typical causes: Generated ID, Timestamp, Unix time) # (typical causes: Generated ID, Timestamp, Unix time)
if details[:file].length == secure_details[:file].length if details[:file].length == secure_details[:file].length
return "The URL #{url} could use HTTPS rather than HTTP" return "The URL #{url} could use HTTPS rather than HTTP"
end end
lenratio = (100 * secure_details[:file].length / details[:file].length).to_i lenratio = (100 * secure_details[:file].length / details[:file].length).to_i
if lenratio >= 90 && lenratio <= 120 if lenratio >= 90 && lenratio <= 120
return "The URL #{url} may be able to use HTTPS rather than HTTP. Please verify it in a browser." return "The URL #{url} may be able to use HTTPS rather than HTTP. Please verify it in a browser."
end
end end
end end